[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: arm: include .text.cold and .text.unlikely in text area

>>> On 10.06.14 at 11:07, <Ian.Campbell@xxxxxxxxxx> wrote:
> On Tue, 2014-06-10 at 09:50 +0100, Jan Beulich wrote:
>> >>> On 09.06.14 at 16:28, <ian.campbell@xxxxxxxxxx> wrote:
>> > Otherwise functions in these sections can end up between .text and .rodata
>> > which is after _etext and therefore gets made non-executable.
>> > 
>> > This matches x86 (although it was done there for different reasons).
>> > 
>> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> > Cc: Jan Beulich <JBeulich@xxxxxxxx>
>> > ---
>> > Jan, any reason why x86 doesn't just use .text.*?
>> Because we want the .cold and .unlikely all adjacent, rather than
>> intermixed with eventual other ones (imagine mixing in a
>> hypothetical .text.hot).
> That makes sense. Could we specify .text.* after those as a fallback or
> would we rather deal with each new section specifically so we can have a
> think about the right location?

That's certainly an option - placing them inefficiently is clearly
better than placing them wrongly.

> I don't suppose there is a linker option to make it barf on
> non-explicitly placed sections, is there? That would have turned this
> silent (and hard to diagnose) failure into something more explicit.

I'm not aware of any such option.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.