[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 5/6] xen: arm: add some helpers for assessing p2m pte
On Tue, 2014-06-10 at 13:52 +0100, Julien Grall wrote: > >>>> Indeed, the can only get the address if the pte is pointed to a memory > >>>> block. > >>> > >>> Yes, but an L3 PTE has the table bit set, which would make > >>> p2m_entry(pte) false... > >> > >> Hmmm... right. But this bit (ie table bit) doesn't have the same meaning > >> on L3. Your comment on p2m_table is confusing. > > > > You mean: /* Remember: L3 entries set the table bit! */ ? > > > > That was intended to be a comment on the two helpers which follow. Do > > you have an idea how I could make it clearer? Perhaps appending "So > > these two functions will return the opposite to what you expect for L3 > > ptes"? > > I was thinking something like "These two functions are only valid for L1 > and L2 ptes". I think I'll do some combination of both. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |