Re: [Xen-devel] [PATCH v3 6/6] tools/libxc: Add Valgrind client requests

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-06-10 at 15:41 +0100, Andrew Cooper wrote:
> Valgrind client requests can be used by code to provide extra debugging
> information about memory ranges, or to request checks at specific points.
> 
> Reference:
>   http://valgrind.org/docs/manual/mc-manual.html#mc-manual.clientreqs
> 
> Client requests are safe to compile into code for running outside of
> valgrind.  Therefore, enable client requests whenever autoconf can find
> memcheck.h and debug builds are enabled.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked + applied.

I'm assuming you have check for unused variable warnings in
non-debug/non-valgrind configurations. I suppose it is unlikely that
those two parameters would be used only for this check.

> ---
> 
> Please rerun autogen as part of committing this

Done.





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel