Re: [Xen-devel] [PATCH v5 RFC 14/14] tools/libxc: noarch restore code

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 11/06/14 19:14, Andrew Cooper wrote:
> --- a/tools/libxc/saverestore/common.h
> +++ b/tools/libxc/saverestore/common.h
> @@ -292,6 +292,12 @@ static inline int write_record(struct context *ctx, 
> struct record *rec)
>      return write_split_record(ctx, rec, NULL, 0);
>  }
>  
> +/* TODO - find a better way of hiding this.  It should be private to
> + * restore.c, but is needed by x86_pv_localise_page()
> + */
> +int populate_pfns(struct context *ctx, unsigned count,
> +                  const xen_pfn_t *original_pfns, const uint32_t *types);

I don't see a problem with this being here, if it's needed in those two
places.

David


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel