[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 11/21] xen/arm: prefix byte_read and byte_write functions with vgic



Hi Vijay,

On 12/06/14 14:36, vijay.kilari@xxxxxxxxx wrote:
From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

prefix byte_read and byte_write vgic functions with vgic_
to make these function vgic specific.

For one patch you are exposing byte_read and byte_write globally. I think, you should rename the function in first and then move them to the headers.

So I would move this patch before #10.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.