[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 11/21] xen/arm: prefix byte_read and byte_write functions with vgic



Hi Vijay,

On 12/06/14 14:36, vijay.kilari@xxxxxxxxx wrote:
@@ -557,7 +557,7 @@ static int vgic_distr_mmio_write(struct vcpu *v, 
mmio_info_t *info)
          if ( dabt.size == 2 )
              rank->itargets[REG_RANK_INDEX(8, gicd_reg - GICD_ITARGETSR)] = *r;
          else
-            byte_write(&rank->itargets[REG_RANK_INDEX(8, gicd_reg - 
GICD_ITARGETSR)],
+            vgic_byte_write(&rank->itargets[REG_RANK_INDEX(8, gicd_reg - 
GICD_ITARGETSR)],
                         *r, offset);

Please correctly realign the second line.

          vgic_unlock_rank(v, rank);
          return 1;
@@ -570,7 +570,7 @@ static int vgic_distr_mmio_write(struct vcpu *v, 
mmio_info_t *info)
          if ( dabt.size == 2 )
              rank->ipriority[REG_RANK_INDEX(8, gicd_reg - GICD_IPRIORITYR)] = 
*r;
          else
-            byte_write(&rank->ipriority[REG_RANK_INDEX(8, gicd_reg - 
GICD_IPRIORITYR)],
+            vgic_byte_write(&rank->ipriority[REG_RANK_INDEX(8, gicd_reg - 
GICD_IPRIORITYR)],
                         *r, offset);

Same here.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.