Re: [Xen-devel] [PATCH v5 18/21] xen/arm: Add virtual GICv3 support

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

I didn't look very closely to each part of this patch. But it looks good 
to me. I've only one question, see below.
On 12/06/14 14:36, vijay.kilari@xxxxxxxxx wrote:
> +static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info)
[..]

> +    case GICD_IROUTER32 ... GICD_IROUTERN:
> +        if ( dabt.size != DABT_DOUBLE_WORD ) goto bad_width;
> +        rank = vgic_irq_rank(v, 64, gicd_reg - GICD_IROUTER, DABT_DOUBLE_WORD);
You've handled word read-access a bit above. Why don't you handle word 
write-access?
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel