Re: [Xen-devel] [PATCH v5 18/21] xen/arm: Add virtual GICv3 support

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Mon, Jun 16, 2014 at 12:02 AM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Vijay,
>
> I didn't look very closely to each part of this patch. But it looks good to
> me. I've only one question, see below.
>
>
> On 12/06/14 14:36, vijay.kilari@xxxxxxxxx wrote:
>>
>> +static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info)
>
>
> [..]
>
>
>> +    case GICD_IROUTER32 ... GICD_IROUTERN:
>> +        if ( dabt.size != DABT_DOUBLE_WORD ) goto bad_width;
>> +        rank = vgic_irq_rank(v, 64, gicd_reg - GICD_IROUTER,
>> DABT_DOUBLE_WORD);
>
>
> You've handled word read-access a bit above. Why don't you handle word
> write-access?
  OK. I will remove byte read-access. 64-bit IROUTER<n> is per irq.
So byte access has no meaning.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel