Re: [Xen-devel] [PATCH v5 RFC 11/14] tools/libxc: x86 HVM save code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 18:07 +0100, Andrew Cooper wrote:
> On 12/06/14 16:55, David Vrabel wrote:
> > On 11/06/14 19:14, Andrew Cooper wrote:
> >> --- /dev/null
> >> +++ b/tools/libxc/saverestore/save_x86_hvm.c
> > ...
> >> +static int write_hvm_params(struct context *ctx)
> >> +{
> > ...
> >> +
> >> +    for ( i = 0; i < ARRAY_SIZE(params); i++ )
> >> +    {
> >> +        uint32_t index = params[i];
> >> +        uint64_t value;
> >> +
> >> +        rc = xc_get_hvm_param(xch, ctx->domid, index, (unsigned long 
> >> *)&value);
> >> +        if ( rc )
> >> +        {
> >> +            /* Gross XenServer hack. Consider HVM_PARAM_CONSOLE_PFN 
> >> failure
> >> +             * nonfatal. This is related to the fact it is impossible to
> >> +             * distinguish "no console" from a console at pfn/evtchn 0.
> >> +             *
> >> +             * TODO - find a compatible way to fix this.
> >> +             */
> >> +            if ( index == HVM_PARAM_CONSOLE_PFN )
> >> +                continue;
> > Um. Is this really needed with upstream Xen?
> >
> > David
> 
> What is needed with upstream Xen is way of representing "no console". 

When and how does this situation arise?

AFAICT with upstream Xen there is always a console in the special pfn
area.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel