[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC OSSTEST 6/9] Toolstack: Refactor guest lifecycle.

On mar, 2014-06-17 at 16:26 +0100, Ian Campbell wrote:
> Implement destory/create as per toolstack methods, including implementing the
> libvirt version which previously didn't work. To do this we use the virsh
> capability to convert an xl/xm style config file into the correct XML.
> xend basically calls into the xl helper since they are compatible.
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---

> +sub create ($$) {
> +    my ($self,$cfg) = @_;
> +    my $ho = $self->{Host};
> +    my $lcfg = $cfg;
> +    $lcfg =~ s,/,-,g;
> +    $lcfg = "$ho->{Name}--$lcfg";
> +    target_cmd_root($ho, "virsh domxml-from-native xen-xm $cfg > $cfg.xml", 
> 30);
> +    target_getfile_root($ho,60,"$cfg.xml", "$stash/$lcfg");
> +    target_cmd_root($ho, "virsh create --file $cfg.xml", 100);
> +}
> +
I agree that domxml-from-native would be the best thing to do here.

However, we need to double check how well it works, and probably commit
to improve that, as, last time I checked, it was doing a pretty poor
job. :-(

Jim, what's the status of that thing?


<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.