Re: [Xen-devel] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-19 at 00:15 -0600, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
> >   
> >> +        if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
> >>     
> >
> > This was subtly broken. The default needs to be "".
> >   
> 
> Turns out, it wasn't :).  Prior to this patch, def->os.cmdline was set
> to NULL if 'extra' did not exist or was empty.  I pushed a fix to
> restore the behavior, as your original patch did
> 
> https://www.redhat.com/archives/libvir-list/2014-June/msg00857.html

Sorry about that and thanks for the fix.

I see VIR_STRDUP actually does handle NULL input correctly, which was
what I was worried about.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel