Re: [Xen-devel] [PATCH] slightly consolidate code in free_domheap_pages()

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Fri, 2014-06-20 at 13:40 +0100, Jan Beulich wrote:

> +        if ( likely(d) && likely(d != dom_cow) )

OOI is this more or less efficient than a single likely around the
entire thing?

> +        else
> +        {
> +            ASSERT(!d || !order);

Is this effectively replacing the ASSERT(order == 0) In the previous d
== dom_cow case?

If so, can d at this point ever be anything other than dom_cow or NULL?
I don't think so. Given that I think ASSERT(!(d == dom_cow && order !=
0)) would more clearly capture the intent of the test (with the spelling
out of the conditions being more important than the de morganing of the
expression).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel