Re: [Xen-devel] [PATCH RFC OSSTEST 7/9] Toolstack: Abstract away migration support check.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-23 at 15:28 -0600, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Tue, 2014-06-17 at 16:26 +0100, Ian Campbell wrote:
> >   
> >> Not implemented for libvirt (the check that is)
> >>     
> >
> > Jim,
> >
> > What would be the right thing to do for this? The intention is for
> > osstest to skip migration tests when that feature is unimplemented by
> > the toolstack/xen/arch combination.
> >
> > It looks like the output of "virsh capabilities" indicates migration:
> >     <migration_features>
> >       <live/>
> >       <uri_transports>
> >         <uri_transport>tcp</uri_transport>
> >       </uri_transports>
> >     </migration_features>
> > is that the right place to look?
> >   
> 
> Yes.
> 
> > Will this capability be automagically suppressed on ARM until we
> > implement it?
> 
> Unfortunately, no :-/.  Currently, the libvirt libxl driver will include
> <migration_features> and call save, restore, and migrate regardless of arch.
> 
> >  FYI xl uses LIBXL_HAVE_NO_SUSPEND_RESUME to figure this
> > out...
> >   
> 
> Ah, interesting.  Thanks for the tip.  I'll need to add similar logic in
> the libxl driver.

Great, thanks.

If my patches to enable osstest virsh support (they need a bit of work
anyway) were to go in before this then ts-migration-check test case will
turn from pass to fail which will look like a regression (even though
ts-migrate which it gates was failing). That's not the end of the world
and we could force osstest to ignore the old spurious passes.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel