Re: [Xen-devel] [PATCH v3 2/5] configure: make the libaio test conditional on blktap{1, 2}

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-19 at 19:46 +0200, Roger Pau Monnà wrote:
> On 19/06/14 19:35, Wei Liu wrote:
> > On Thu, Jun 19, 2014 at 06:32:45PM +0200, Roger Pau Monne wrote:
> >> libaio is only required for blktap{1,2}, so make the check conditional
> >> on whether the user has requested blktap{1,2} or not.
> >>
> >> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> >> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> >> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >> ---
> >> Please re-run autoconf after applying this patch.
> >> ---
> >> Changes since v2:
> >>  - Make libaio test conditional on whether blktap2 is also enabled.
> >> ---
> >>  tools/configure.ac |    2 ++
> >>  1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/tools/configure.ac b/tools/configure.ac
> >> index 836bbba..6d70f04 100644
> >> --- a/tools/configure.ac
> >> +++ b/tools/configure.ac
> >> @@ -262,7 +262,9 @@ AC_CHECK_HEADER([lzo/lzo1x.h], [
> >>  AC_CHECK_LIB([lzo2], [lzo1x_decompress], [zlib="$zlib -DHAVE_LZO1X 
> >> -llzo2"])
> >>  ])
> >>  AC_SUBST(zlib)
> >> +AS_IF([test "x$enable_blktap1" = "xyes" || test "x$enable_blktap2" = 
> >> "xyes"], [
> >>  AC_CHECK_LIB([aio], [io_setup], [], [AC_MSG_ERROR([Could not find 
> >> libaio])])
> >> +])
> > 
> > Libaio is needed by QEMU as well.
> 
> Not on FreeBSD, and Qemu already runs it's own configure script, so I
> don't think we need to check for everything that Qemu needs here.

We do check for some stuff because qemu needs it, so we can fail sooner.
I'm happy to ack and accept this patch as it is though.

I'd really like to see if we could pull the clone of external trees
earlier so we can run qemu's configure sooner and perhaps fail sooner.
I'm even wondering if we can cause things to be cloned at configure
time.

Anyway, one for another day, I reckon.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel