Re: [Xen-devel] [PATCH v2 18/21] xen/passthrough: dt: Add new domctl XEN_DOMCTL_assign_dt_device

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.07.14 at 17:00, <julien.grall@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -343,6 +343,13 @@ int iommu_do_domctl(
>      ret = iommu_do_pci_domctl(domctl, d, u_domctl);
>  #endif
>  
> +    if ( ret != -ENOSYS )
> +        return ret;
> +
> +#ifdef HAS_DEVICE_TREE
> +    ret = iommu_do_dt_domctl(domctl, d, u_domctl);
> +#endif

I think the if() (with the condition inverted) should be moved inside
the #ifdef.

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -984,6 +984,14 @@ struct xen_domctl_dtdev_op {
>  typedef struct xen_domctl_dtdev_op xen_domctl_dtdev_op_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_domctl_dtdev_op_t);
>  
> +/* Device Tree: Assign a non-PCI device to a guest */
> +struct xen_domctl_assign_dt_device {
> +    uint32_t size; /* IN: Length of the path */
> +    XEN_GUEST_HANDLE_64(char) path; /* IN: path to the device tree node */

Missing padding again?

Also, no XSM adjustment needed this time?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel