Re: [Xen-devel] [PATCH v2 1/2] cmdline_parse: Convert no- prefix into =no for OPT_CUSTOM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.14 at 12:58, <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2014-07-30 at 08:58 +0100, Jan Beulich wrote:
>> convert "no-" command line option prefix into "=no" for OPT_CUSTOM
>> 
>> ... to allow restoring/retaining previous behavior for options getting
>> converted from boolean to custom.
>> 
>> Reported-by: Don Slutz <dslutz@xxxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/xen/common/kernel.c
>> +++ b/xen/common/kernel.c
>> @@ -135,6 +135,13 @@ void __init cmdline_parse(const char *cm
>>                      parse_size_and_unit(optval, NULL));
>>                  break;
>>              case OPT_CUSTOM:
>> +                if ( !bool_assert )
>> +                {
>> +                    if ( *optval )
>> +                        break;
> 
> I think this results in silently ignoring mad combinations, rather than
> reporting them as an error. If that was what you intended then:

Yes, it was (mentioned in the thread that led here): The resulting
message is only of limited use, as it wouldn't possibly make it to
the (serial) console.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel