Re: [Xen-devel] [PATCH v10] xen/arm : emulation of arm's PSCI v0.2 standard

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-31 at 16:15 +0530, Parth Dixit wrote:
> Arm based virtual machines dom0/guest will request power related functionality
> from xen through PSCI interface. This patch implements version 0.2 of
> PSCI standard specified by arm for 64bit and 32 bit arm machines.
> 
> - removed arm_psci_fn_t
> - implemented psci_cpu_on with additional error conditions
> - added switch-case in do_trap_psci function
> - added PSCI v0.2 macros in psci.h
> - removed tables for PSCI v0.1 and v0.2
> - implemented affinity_info
> - moved do_common_cpu up in vpsci.c removed declaration
> - removed PSCI_ARGS macro
> - added new macro for 32 bit arguments
> - added new function psci_mode_check
> - modified cpu_suspend to return context_id
> - added macros for checking powe_state

What was this? Looked like a misplaced intra-posting changelog? Please
delete or move.

I was about to ack + applied, but on arm32:
        traps.c: In function âdo_trap_psciâ:
        traps.c:1089:28: error: âstruct cpu_user_regsâ has no member named 
âregs0â
        traps.c:1097:37: error: âstruct cpu_user_regsâ has no member named 
âregs1â
        traps.c:1103:37: error: âstruct cpu_user_regsâ has no member named 
âregs1â
        traps.c:1104:39: error: âstruct cpu_user_regsâ has no member named 
âregs2â
        traps.c:1134:39: error: âstruct cpu_user_regsâ has no member named 
âregs1â
        traps.c:1135:39: error: âstruct cpu_user_regsâ has no member named 
âregs2â
        traps.c:1136:36: error: âstruct cpu_user_regsâ has no member named 
âregs3â
        traps.c:1145:37: error: âstruct cpu_user_regsâ has no member named 
âregs1â
        traps.c:1146:39: error: âstruct cpu_user_regsâ has no member named 
âregs2â
        traps.c:1147:36: error: âstruct cpu_user_regsâ has no member named 
âregs3â
        traps.c:1156:37: error: âstruct cpu_user_regsâ has no member named 
âregs1â
        traps.c:1157:35: error: âstruct cpu_user_regsâ has no member named 
âregs2â
        traps.c:1166:35: error: âstruct cpu_user_regsâ has no member named 
âregs1â

Looks like some cpp pasting isn't doing what you expected. Please at
least compile test for 32-bit as well. Although given the interesting
nature of the smc32 vs smc64 logic I would kind of hope that you might
test 32-bit too.

> +register_t do_psci_0_2_cpu_suspend(uint32_t power_state, register_t 
> entry_point,
> +                            register_t context_id)
> +{
> +    struct vcpu *v = current;
> +
> +    /* Power off requests are treated as performing standby
> +     * as this simplifies xen implementation */

I was going to let this slide, but since you need to resend anyway:

Xen comment style would be:

    /*
     * Power off requests are treated as performing standby
     * as this simplifies the Xen implementation.
     */

i.e. "hanging" /* and */, plus a full stop. also "the Xen
implementation" for grammar.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel