[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC V4 4/5] xen, libxc: Request page fault injection via libxc

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Tue, 05 Aug 2014 11:09:31 +0300
  • Cc: kevin.tian@xxxxxxxxx, ian.campbell@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, eddie.dong@xxxxxxxxx, xen-devel@xxxxxxxxxxxxx, jun.nakajima@xxxxxxxxx, ian.jackson@xxxxxxxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Tue, 05 Aug 2014 08:10:00 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=l/5beF3GrCoRAoQu4AEmKgOM1Z+jppbN2+oC6UTByzHZmkBK/tL358Qo+Z9BaswGvdtjKUwBa+KT5P0V9InM7Lij0A6nAX3HefPiu/pzImjJ1hteAnUdoW5l8z4FFHajT8r63/tGbAYS/86siMj5CGxks2bPRPkA644ZS4GfY5cee+dAwZPTY5T/4PHAxWOF1GVhlfwQ3Y2wszl+I69Cu83xBHj2o5IbNe1JYFULERAEKyvNqX3XbrW0pYIgKO6RWWR1zD6RSf9gHqQ6yk1nz8ylcc71BSliQsI0y2j6vSPyVw0lTmqtHZXXL7YHRHOoeFBKR/CwYSATRZRjE4n66g==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 08/04/2014 06:20 PM, Jan Beulich wrote:
>>>> On 04.08.14 at 17:00, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>> On 08/04/2014 05:26 PM, Jan Beulich wrote:
>>>>>> On 04.08.14 at 13:30, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>>> +    __vmread(VM_ENTRY_INTR_INFO, &ev);
>>>> +
>>>> +    if ( (ev & INTR_INFO_VALID_MASK) &&
>>>> +         hvm_event_needs_reinjection((ev >> 8) & 7, ev & 0xff) )
>>> Are there no manifest constants for all these plain numbers?
>> If there are, vmx_vmcs_save() in vmx.c (line 416) doesn't use them. I've
>> copied that part verbatim.
> And that's precisely the problem: As long as there's exactly one use
> site, the need for manifest constants is questionable (i.e. largely
> cosmetic). As soon as there are multiple places, connecting them
> together is largely impossible without naming these numbers - only
> that way you have a reasonable chance to find the clone of the
> original should the original be found to need tweaking.

I'll gladly add #defines for those magic constants, but could you please
recommend names for them and a header (or at least, category of headers)
to put them in, in the interest of minimizing the number of RFC versions
for this series?

Razvan Cojocaru

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.