Re: [Xen-devel] [PATCH v4 2/3] x86/viridian: Make logging less verbose

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper [mailto:amc96@xxxxxxxxxxxxxxxx] On Behalf Of
> Andrew Cooper
> Sent: 05 August 2014 10:54
> To: Paul Durrant; xen-devel@xxxxxxxxxxxxx
> Cc: Keir (Xen.org); Jan Beulich
> Subject: Re: [Xen-devel] [PATCH v4 2/3] x86/viridian: Make logging less
> verbose
> 
> On 05/08/2014 10:44, Paul Durrant wrote:
> > The use of gdprintk() adds uninteresting prefixes to the log lines, and
> > there's really too many lines. This patch reduces the verbosity.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Cc: Keir Fraser <keir@xxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> >  xen/arch/x86/hvm/viridian.c |   53 ++++++++++++++++++++++++----------
> ---------
> >  1 file changed, 30 insertions(+), 23 deletions(-)
> >
> > diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c
> > index 31c9656..9000375 100644
> > --- a/xen/arch/x86/hvm/viridian.c
> > +++ b/xen/arch/x86/hvm/viridian.c
> > @@ -120,37 +120,44 @@ int cpuid_viridian_leaves(unsigned int leaf,
> unsigned int *eax,
> >
> >  static void dump_guest_os_id(const struct domain *d)
> >  {
> > -    gdprintk(XENLOG_INFO, "GUEST_OS_ID:\n");
> > -    gdprintk(XENLOG_INFO, "\tvendor: %x\n",
> > -            d->arch.hvm_domain.viridian.guest_os_id.fields.vendor);
> > -    gdprintk(XENLOG_INFO, "\tos: %x\n",
> > -            d->arch.hvm_domain.viridian.guest_os_id.fields.os);
> > -    gdprintk(XENLOG_INFO, "\tmajor: %x\n",
> > -            d->arch.hvm_domain.viridian.guest_os_id.fields.major);
> > -    gdprintk(XENLOG_INFO, "\tminor: %x\n",
> > -            d->arch.hvm_domain.viridian.guest_os_id.fields.minor);
> > -    gdprintk(XENLOG_INFO, "\tsp: %x\n",
> > -            d->arch.hvm_domain.viridian.guest_os_id.fields.service_pack);
> > -    gdprintk(XENLOG_INFO, "\tbuild: %x\n",
> > -            d->arch.hvm_domain.viridian.guest_os_id.fields.build_number);
> > +    const union viridian_guest_os_id *goi;
> > +
> > +    goi = &d->arch.hvm_domain.viridian.guest_os_id;
> > +
> > +    printk(XENLOG_G_INFO "d%d: GUEST_OS_ID: vendor: %x os: %x
> major: %x minor: %x sp: %x build: %x\n",
> > +           d->domain_id,
> > +           goi->fields.vendor,
> > +           goi->fields.os,
> > +           goi->fields.major,
> > +           goi->fields.minor,
> > +           goi->fields.service_pack,
> > +           goi->fields.build_number);
> >  }
> >
> >  static void dump_hypercall(const struct domain *d)
> >  {
> > -    gdprintk(XENLOG_INFO, "HYPERCALL:\n");
> > -    gdprintk(XENLOG_INFO, "\tenabled: %x\n",
> > -            d->arch.hvm_domain.viridian.hypercall_gpa.fields.enabled);
> > -    gdprintk(XENLOG_INFO, "\tpfn: %lx\n",
> > -            (unsigned long)d-
> >arch.hvm_domain.viridian.hypercall_gpa.fields.pfn);
> > +    const union viridian_hypercall_gpa *hg;
> > +
> > +    hg = &d->arch.hvm_domain.viridian.hypercall_gpa;
> > +
> > +    printk(XENLOG_G_INFO "d%d: HYPERCALL: enabled: %x pfn: %lx\n",
> > +           d->domain_id,
> > +           hg->fields.enabled,
> > +           (unsigned long)hg->fields.pfn);
> >  }
> >
> >  static void dump_apic_assist(const struct vcpu *v)
> >  {
> > -    gdprintk(XENLOG_INFO, "APIC_ASSIST[%d]:\n", v->vcpu_id);
> > -    gdprintk(XENLOG_INFO, "\tenabled: %x\n",
> > -            v->arch.hvm_vcpu.viridian.apic_assist.fields.enabled);
> > -    gdprintk(XENLOG_INFO, "\tpfn: %lx\n",
> > -            (unsigned 
> > long)v->arch.hvm_vcpu.viridian.apic_assist.fields.pfn);
> > +    struct domain *d = v->domain;
> > +    const union viridian_apic_assist *aa;
> > +
> > +    aa = &v->arch.hvm_vcpu.viridian.apic_assist;
> > +
> > +    printk(XENLOG_G_INFO "d%dv%d: APIC_ASSIST: enabled: %x pfn:
> %lx\n",
> > +           d->domain_id,
> > +           v->vcpu_id,
> 
> %pv and just pass the vcpu.
> 

Didn't know about that one. Ta,

  Paul

> ~Andrew
> 
> > +           aa->fields.enabled,
> > +           (unsigned long)aa->fields.pfn);
> >  }
> >
> >  static void enable_hypercall_page(struct domain *d)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel