Re: [Xen-devel] [PATCH ARM v6 00/14] mini-os: initial ARM support

[Thomas Leonard <talex5@xxxxxxxxx>]

On 18 July 2014 13:45, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>
> On Wed, 2014-07-16 at 12:07 +0100, Thomas Leonard wrote:
>
> I tried to apply:
> mini-os: x86_64: make thread stacks 16-byte aligned
> mini-os: don't include lib.h from mm.h (the second, attached, version)
> mini-os: added HYPERVISOR_xsm_op
> mini-os: use generic local_irq_enable function
>
> but got:
>         vtpm_cmd_handler.c: In function âtm_dhkx_genâ:
>         vtpm_cmd_handler.c:486:3: error: implicit declaration of function 
> âARRAY_SIZEâ [-Werror=implicit-function-declaration]
>         cc1: all warnings being treated as errors
>         make[2]: *** [vtpm_cmd_handler.o] Error 1
>         make[2]: *** Waiting for unfinished jobs....
>         disk_tpm.c: In function âTPM_disk_sealâ:
>         disk_tpm.c:84:2: error: implicit declaration of function âprintkâ 
> [-Werror=implicit-function-declaration]
>         cc1: all warnings being treated as errors
>         make[2]: *** [disk_tpm.o] Error 1
>         make[2]: Entering directory 
> `/local/scratch/ianc/devel/committer-amd64.git/stubdom/libxc-x86_64'
>         make libs
>
> Which I think was the mm.h one.

Oops. The attached updated patch fixes compiling the stubdoms for me.

> Then I got:
>         In file included from 
> /local/scratch/ianc/devel/committer-amd64.git/stubdom/../extras/mini-os/include/mini-os/gntmap.h:4:0,
>                          from 
> /local/scratch/ianc/devel/committer-amd64.git/stubdom/../extras/mini-os/include/mini-os/lib.h:55,
>                          from 
> /local/scratch/ianc/devel/committer-amd64.git/stubdom/../extras/mini-os/include/mini-os/mm.h:36,

I guess this is just due to skipping the previous patch, since after
that mm.h will no longer inlcude lib.h.


-- 
Dr Thomas Leonard        http://0install.net/
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA

Attachment: 0001-mini-os-don-t-include-lib.h-from-mm.h.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel