Re: [Xen-devel] [PATCH v6 05/10] libxl: vnuma topology configuration parser and doc

[Elena Ufimtseva <ufimtseva@xxxxxxxxx>]

On Tue, Jul 29, 2014 at 6:42 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2014-07-18 at 01:50 -0400, Elena Ufimtseva wrote:
>> diff --git a/tools/libxl/libxl_vnuma.h b/tools/libxl/libxl_vnuma.h
>> new file mode 100644
>> index 0000000..4ff4c57
>> --- /dev/null
>> +++ b/tools/libxl/libxl_vnuma.h
>> @@ -0,0 +1,8 @@
>
> Needs the normal guards against repeated inclusion.
>
> Is this intended to be an internal header? If it is to be used by
> applications then the things which it defines should be correctly
> namespaced.
>

Thanks Ian for your review.
Sorry for late response, I had to work on some day job related things.
I will address your comments in the next series of patches.

Elena

>> +#include "libxl_osdeps.h" /* must come before any other headers */
>> +
>> +#define VNUMA_NO_NODE ~((unsigned int)0)
>> +
>> +/* Max vNUMA node size from Linux. */
>> +#define MIN_VNODE_SIZE  32U
>> +
>> +#define MAX_VNUMA_NODES (unsigned int)1 << 10
>
> Ian.
>



-- 
Elena

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel