Re: [Xen-devel] [PATCH] tools/tests: Add EIP check to test_x86_emulator.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.14 at 10:18, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 07/08/2014 09:16, Razvan Cojocaru wrote:
>> The test now also checks that EIP was modified after emulating
>> instructions after (and including) the "movq %mm3,(%ecx)..."
>> code block.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> 
> These checks do check that the instruction pointer has changed, which
> catches your problem, but doesn't check that it has changed correctly. 
> You need to work out exactly how long the instruction is a verify that
> eip points to first byte of the next instruction.

And apart from that this should be done for all tests, not just the
MMX/SSE/AVX ones.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel