Re: [Xen-devel] [PATCH v3 0/3] map grant refs at pfn = mfn

[Thomas Leonard <talex5@xxxxxxxxx>]

On 7 August 2014 11:40, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Aug 07, 2014 at 08:59:30AM +0100, Thomas Leonard wrote:
> [...]
>> >
>> > If you do "ps aux | grep vif" do you see some kthreads? If so, what is
>> > the status of these threads?
>>
>> root@cubietruck:~# xl list
>> Name                                        ID   Mem VCPUs      State   
>> Time(s)
>> Domain-0                                     0   512     2     r-----      
>> 22.0
>> (null)                                       1     0     1     --ps-d       
>> 0.1
>>
>> root@cubietruck:~# ps aux | grep vif
>> root      1189  0.0  0.0      0     0 ?        S    07:50   0:00
>> [vif1.0-q0-guest]
>> root      1190  0.0  0.0      0     0 ?        S    07:50   0:00
>> [vif1.0-q0-deall]
>> root      1242  0.0  0.2   3388  1052 pts/0    S+   07:51   0:00 grep
>> --color=auto vif
>>
>> > What's the status of "xenwatch" thread?
>>
>> root@cubietruck:~# ps aux | grep xenwatch
>> root        18  0.0  0.0      0     0 ?        D    07:49   0:00 [xenwatch]
>>
>> root@cubietruck:~# cat /proc/18/wchan
>> xenvif_disconnect
>>
>
> OK, so the ref-count is messed up. My patch is buggy.
>
> Another simplier fix came to mind this morning. Can you give it a go?
> I've run preliminary test on x86, this patch at least doesn't cause
> regression for me.

Seems to be working. I did get this on the console:

[  156.933721] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.933787] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.933823] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.933869] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.933903] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.933936] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.933969] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.934002] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.934035] vif vif-1-0 vif1.0: Page still granted! Index: bd
[  156.934069] vif vif-1-0 vif1.0: Page still granted! Index: bd

But the domU was cleaned up and the second one didn't generate any
output. The third gave:

[  209.226154] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226206] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226239] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226270] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226302] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226333] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226364] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226395] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226427] vif vif-3-0 vif3.0: Page still granted! Index: b7
[  209.226458] vif vif-3-0 vif3.0: Page still granted! Index: b7

Apart from displaying these messages, it seems to be working fine.


-- 
Dr Thomas Leonard        http://0install.net/
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel