[Xen-devel] [PATCH net-next v2] xen-netback: Fix vif->disable handling

[Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>]

In the patch called "xen-netback: Turn off the carrier if the guest is not able
to receive" new branches were introduced to this if statement, risking that a
queue with non-zero id can reenable the disabled interface.

Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
---
v2: fix a code style error in this "if" as well

diff --git a/drivers/net/xen-netback/netback.c 
b/drivers/net/xen-netback/netback.c
index aa20933..4734472 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -2025,9 +2025,15 @@ int xenvif_kthread_guest_rx(void *data)
                 * context so we defer it here, if this thread is
                 * associated with queue 0.
                 */
-               if (unlikely(queue->vif->disabled && queue->id == 0))
+               if (unlikely(queue->vif->disabled && queue->id == 0)) {
                        xenvif_carrier_off(queue->vif);
-               else if 
(unlikely(test_and_clear_bit(QUEUE_STATUS_RX_PURGE_EVENT,
+               } else if (unlikely(queue->vif->disabled)) {
+                       /* kthread_stop() would be called upon this thread soon,
+                        * be a bit proactive
+                        */
+                       skb_queue_purge(&queue->rx_queue);
+                       queue->rx_last_skb_slots = 0;
+               } else if 
(unlikely(test_and_clear_bit(QUEUE_STATUS_RX_PURGE_EVENT,
                                                     &queue->status))) {
                        xenvif_rx_purge_event(queue);
                } else if (!netif_carrier_ok(queue->vif->dev)) {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel