[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/3] Introduce xensock socket and implement sockback and sockfront drivers

To: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx>
From: Wei Liu <wei.liu2@xxxxxxxxxx>
Date: Fri, 8 Aug 2014 16:27:42 +0100
Cc: Tim Deegan <tim@xxxxxxx>, wei.liu2@xxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
Delivery-date: Fri, 08 Aug 2014 15:28:01 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Yes you've hooked it up to socket layer but for large part it's
duplication of old (and possible buggy) code -- 3.10 netfront/back.

I think you should first state why this new driver is needed. You will
also need to refactor your code, so that it depends on xen-netback /
front. Code duplication like this is not acceptable upstream.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH 0/3] Introduce xensock socket and implement sockback and sockfront drivers
  - From: Oleksandr Dmytryshyn

References:
- [Xen-devel] [PATCH 0/3] Introduce xensock socket and implement sockback and sockfront drivers
  - From: Oleksandr Dmytryshyn

Prev by Date: Re: [Xen-devel] [PATCH] evtchn: clean last_vcpu_id on EVTCHNOP_reset to avoid crash
Next by Date: Re: [Xen-devel] [RFC][PATCH 1/5] xen:x86: record RMRR mappings
Previous by thread: Re: [Xen-devel] [PATCH 0/3] Introduce xensock socket and implement sockback and sockfront drivers
Next by thread: Re: [Xen-devel] [PATCH 0/3] Introduce xensock socket and implement sockback and sockfront drivers
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.