Re: [Xen-devel] [PATCH RFC 3/7] xen: Add multiboot2.h header file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.08.14 at 01:04, <daniel.kiper@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/include/xen/multiboot2.h

I have to admit that I can't see why this can't all go into
xen/include/xen/multiboot.h - the two sets of definitions have to be
able to coexist anyway.

> +#ifndef __ASSEMBLY__
> +typedef struct
> +{

These opening braces should all go on the same line as the "struct"
keyword.

> +} multiboot2_tag_efi_mmap_t;
> +#endif /* __ASSEMBLY__ */
> +#endif /* __MULTIBOOT2_H__ */

Blank lines needed between at least the last two lines.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel