Re: [Xen-devel] [PATCH v4 1/3] x86: Consolidate boolean inputs in hvm and p2m into their own respective bitmaps.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.08.14 at 12:53, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> On Mon, Aug 11, 2014 at 10:48 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
>> >>> On 08.08.14 at 20:49, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> >>  +struct p2m_access_check_info {
>> >
>> >> > +    uint8_t read_access:1;
>> >> > +    uint8_t write_access:1;
>> >> > +    uint8_t insn_fetch:1;
>> >> > +    uint8_t gla_valid:1;
>> >> > +    uint8_t have_extra_fault_info:1;
>> >> > +    uint8_t extra_fault_info:1;
>> >> > +};
>> >> > +#define P2M_FAULT_IN_GPT      0u
>> >> > +#define P2M_FAULT_WITH_GLA    1u
>> >>
>> >> Similar comments here; the enum of course could be re-used.
>> >
>> > Where would I need to put that shared enum, which header?
>>
>> Whichever is suitable for all use sites - I'm not seeing a strong need
>> to put it anywhere particular.
> 
> My feeling is that it would fit most into p2m.h. Also, shouldn't we have a
> shared structure for the bitmap declaration as well?

If it's identical between what the mem-event interface wants and
what we need for propagating nested page fault information (also
from an abstract pov), yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel