Re: [Xen-devel] [PATCH net v3 2/3] xen-netback: don't stop dealloc kthread too early

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 11, 2014 at 03:55:08PM +0100, Zoltan Kiss wrote:
> On 11/08/14 11:11, Wei Liu wrote:
> >@@ -1525,10 +1537,13 @@ static int xenvif_handle_frag_list(struct 
> >xenvif_queue *queue, struct sk_buff *s
> >     /* remove traces of mapped pages and frag_list */
> >     skb_frag_list_init(skb);
> >     uarg = skb_shinfo(skb)->destructor_arg;
> >+    /* See comment on set_skb_zerocopy */
> >+    if (uarg->callback == xenvif_zerocopy_callback)
> This condition is not necessary: uarg->callback shouldn't be anything else
> but this xenvif_zerocopy_callback at this point, unless something terribly
> went wrong. In that case we are doomed anyway :)
> 

Right. I was just too cautious.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel