Re: [Xen-devel] [PATCH v6 10/10] libxl: set vnuma for domain

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 11, 2014 at 11:52:55PM -0400, Elena Ufimtseva wrote:
> On Tue, Jul 29, 2014 at 6:45 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Fri, 2014-07-18 at 01:50 -0400, Elena Ufimtseva wrote:
> >> Call xc_domain_setvnuma to set vnuma topology for domain.
> >> Prepares xc_dom_image for domain bootmem memory allocation
> >>
> >> Signed-off-by: Elena Ufimtseva <ufimtseva@xxxxxxxxx>
> >> ---
> >>  tools/libxl/libxl.c |   22 ++++++++++++++++++++++
> >>  tools/libxl/libxl.h |   19 +++++++++++++++++++
> >>  2 files changed, 41 insertions(+)
> >>
> >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> >> index 39f1c28..e9f2607 100644
> >> --- a/tools/libxl/libxl.c
> >> +++ b/tools/libxl/libxl.c
> >> @@ -4807,6 +4807,28 @@ static int libxl__set_vcpuonline_qmp(libxl__gc *gc, 
> >> uint32_t domid,
> >>      return 0;
> >>  }
> >>
> >> +int libxl_domain_setvnuma(libxl_ctx *ctx,
> >> +                            uint32_t domid,
> >
> > Can this be done on an existing domain? I'd have expected this to be an
> > internal function which is called from the inside of the domain creation
> > machinery.
> >
> > Does anything use this? If yes then since this is the last patch you
> > must have introduced a bisection hazard.
> >
> > Ian.
> >
> 
> Ian, Wei
> 
> Preparing the series, I figured that this particular function
> libxl_domain_setvnuma does not have any users. Instead, xc one is
> called directly.
> I want to omit this patch. Do I need to have  #define
> LIBXL_HAVE_DOMAIN_SETVNUMA 1 in this case?
> 

If your macro is specifically for this function then you need to remove
macro as well. In this case I think the answer is "no you don't need
that in libxl.h", unless I've mistaken the purpose of your macro.

Wei.

> Thank you.
> 
> -- 
> Elena
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel