Re: [Xen-devel] [PATCH v9 18/20] x86/VPMU: Save VPMU state for PV guests during context switch

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.08.14 at 18:55, <boris.ostrovsky@xxxxxxxxxx> wrote:
> @@ -1526,12 +1524,12 @@ void context_switch(struct vcpu *prev, struct vcpu 
> *next)
>                             !is_hardware_domain(next->domain));
>      }
>  
> -    if ( is_hvm_vcpu(next) && (prev != next) && (vpmu_mode & 
> XENPMU_MODE_SELF) )
> +    context_saved(prev);
> +
> +    if ( (prev != next) && (vpmu_mode & XENPMU_MODE_SELF) )
>          /* Must be done with interrupts enabled */
>          vpmu_load(next);
>  
> -    context_saved(prev);
> -
>      if ( prev != next )
>          _update_runstate_area(next);
>  

While fine afaict, this re-ordering needs an explanation in the commit
message (and not just in the overview mail).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel