Re: [Xen-devel] [PATCH v6 4/4] tools/xen-access: Print gla valid/fault information

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Tamas K Lengyel writes ("[PATCH v6 4/4] tools/xen-access: Print gla valid/fault 
information"):
> Extend the print-out of the memory violations to show gla valid/fault 
> information.
> 
> v4: Change vcpu-id printf to unsigned and update to new fields.
> v2: Update to new fields and change printing 1/0 to y/n.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
> ---
>  tools/tests/xen-access/xen-access.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/tests/xen-access/xen-access.c 
> b/tools/tests/xen-access/xen-access.c
> index 090df5f..98b3a1c 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -566,13 +566,16 @@ int main(int argc, char *argv[])
>                  }
>  
>                  printf("PAGE ACCESS: %c%c%c for GFN %"PRIx64" (offset %06"
> -                       PRIx64") gla %016"PRIx64" (vcpu %d)\n",
> +                       PRIx64") gla %016"PRIx64" (valid: %c) fault in gpt: 
> %c fault with gla: %c (vcpu %u)\n",

This patch is fine except that the message punctuation could do with
being slightly improved, I think.  Something like this:

   PRIx64") gla %016"PRIx64" (valid: %c; fault in gpt: %c; fault with gla: %c; 
vcpu %u)\n",

unless I have misunderstood the nature of these fields.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel