Re: [Xen-devel] [PATCH v6 2/4] x86/hvm: Treat non-instruction fetch nested page faults also as read violations

[Tamas Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Aug 14, 2014 at 6:49 PM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:

On 14/08/14 17:43, Tian, Kevin wrote:

but doing so just moves from one incomplete solution (where read-modify-write is not treated as read-violation) to another incomplete solution (where all writes are treated read-violation). If there’s actual usage relying on accurate read-violation information, either solution doesn’t work. So I don’t see the value of this change.

I would agree.  Anything using this information will have to have detailed knowledge of what the hardware is capable of reporting, to understand the information it has to hand.

I think Xen should faithfully pass on what hardware reports.  It will be more useful to the consumer than blurring the details like this.

~Andrew

I can get behind both arguments (including this patch or not) so I leave it up to the maintainers to decide. This patch itself is not critical for the rest of the patches in series so it can be omitted if need be.

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel