Re: [Xen-devel] [PATCH v7 2/4] x86/hvm: Treat non-instruction fetch nested page faults also as read violations

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

  +    /* While the hardware doesn't explicitely provide a read access bit
+     * we deduce it from the instruction fetch bit, thus marking only
+     * read and/or write accesses as read accesses. */

This doesn't conform to Xen coding style and since this means you will need to resend this anyway ;-( I'd suggest something along the lines of

/*
 * Since HW doesn't explicitly provide a read access bit and we need to
 * somehow describe read-modify-write instructions we will conservatively
 * set read_access for all memory accesses that are not instruction fetches.
 */

Since I will not be available after today until September and I assume Jan
will want an ack from SVM side for the series here is my

    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

assuming the text above is updated to Jan's liking.

-boris

Thanks! I will update the comment block accordingly.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel