Re: [Xen-devel] [V0 PATCH 4/6] AMD-PVH: Do not get/set vlapic TPR

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> 08/19/14 3:17 AM >>>
>On 08/15/2014 09:53 PM, Mukesh Rathor wrote:
>> --- a/xen/arch/x86/hvm/svm/svm.c
>> +++ b/xen/arch/x86/hvm/svm/svm.c
>> @@ -1052,7 +1052,7 @@ static void noreturn svm_do_resume(struct vcpu *v)
>>           hvm_asid_flush_vcpu(v);
>>       }
>>   
>> -    if ( !vcpu_guestmode )
>> +    if ( !vcpu_guestmode && vcpu_vlapic(v)->regs )
>
>I think checking explicitly for PVH (i.e. is_pvh_domain()) would be 
>better. Here and below, obviously.

Yeah, I guess so for now, as it'll make it easier to locate the place when
ultimately changing to more fine grained checks.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel