[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: minor improvement in smp_send_call_function_mask()

Hi Anup,

On 21/08/14 06:04, Anup Patel wrote:
The best alternative would be cpumask_empty.

All three cpumask_empty(), cpumask_first(), and cpumask_weight()
are O(N) where N is number of bits in cpumask.
It really does not make much difference which of these operation
is chosen.

Hmmm right. That the worst case for all, and always the case for cpumask_weight. Anyway...

Since empty target list is fine with GIC Distributor, I will drop the check.

Assuming you only remove the check in the next version:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.