[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RESEND v7 3/9] vnuma hook to debug-keys u
>>> On 21.08.14 at 18:19, <konrad.wilk@xxxxxxxxxx> wrote: > On Thu, Aug 21, 2014 at 01:10:23AM -0400, Elena Ufimtseva wrote: >> @@ -389,6 +389,34 @@ static void dump_numa(unsigned char key) >> >> for_each_online_node(i) >> printk(" Node %u: %u\n", i, page_num_node[i]); >> + >> + if ( d->vnuma ) { >> + printk(" Domain has %u vnodes, %u vcpus\n", >> d->vnuma->nr_vnodes, d->max_vcpus); Long line. >> + for ( i = 0; i < d->vnuma->nr_vnodes; i++ ) { > > That '{' > needs to be on another line. > >> + >> + err = snprintf(keyhandler_scratch, 12, "%u", >> d->vnuma->vnode_to_pnode[i]); >> + if ( err < 0 || d->vnuma->vnode_to_pnode[i] == >> NUMA_NO_NODE) > > You need a space at the end, so 'NUMA_NO_NODE )' > >> + snprintf(keyhandler_scratch, 3, "???"); >> + printk(" vnode %3u - pnode %s,", i, >> keyhandler_scratch); >> + >> + printk(" %"PRIu64" MB, ", >> + (d->vnuma->vmemrange[i].end - >> d->vnuma->vmemrange[i].start) >> 20); >> + >> + printk("vcpu nrs: "); >> + for ( j = 0, n = 0; j < d->max_vcpus; j++ ) { > > { on its own line. >> + if ( d->vnuma->vcpu_to_vnode[j] == i ) { > > Ditto And, Elena, I have been pointing out these coding style issues on previous iterations. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |