Re: [Xen-devel] [v4][PATCH 2/9] xen:x86: define a new hypercall to get RMRR mappings

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.08.14 at 12:53, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 22/08/14 11:09, Tiejun Chen wrote:
>> +    /* PFN of the current mapping of the page. */
>> +    xen_pfn_t pfn;
>> +    /* Number of the current mapping pages. */
>> +    xen_ulong_t count;
>> +};
> 
> This struct marks a range, but the fields don't make it clear.  I would
> suggest "start" and "nr_frames" as names.

Perhaps "start_pfn" to be even more explicit (and not just
depend on the field's type), and then maybe also "nr_pfns"
or "nr_pages".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel