[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2] Update pvSCSI protocol description



On 08/25/2014 03:14 PM, Jan Beulich wrote:
On 25.08.14 at 14:51, <JGross@xxxxxxxx> wrote:
On 08/25/2014 02:33 PM, Jan Beulich wrote:
On 25.08.14 at 14:13, <"jgross@xxxxxxxx".non-mime.internet> wrote:
+    uint8_t nr_segments;            /* Number of pieces of scatter-gather */
+#define VSCSIIF_SG_GRANT    0x80    /* flag: SG elements via grant page */
+                                    /* nr_segments counts grant pages with
+                                       SG elements.
+                                       usable if "feature-sg-grant" set */

Is that really accurate? If said value is to go into nr_segments,
all such requests would have to have exactly 128 "grant pages
with SG elements".

Have you read the comment just above the #define of VSCSIIF_ACT_SCSI_CDB
describing the interface?

Yes, but
- people looking here don't necessarily also look there
- it being correct there doesn't provide room for it getting
   described incorrectly here

Aah, now I understand your comment. I'll adjust the comment.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.