Re: [Xen-devel] [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410)

[Suriyan Ramasami <suriyan.r@xxxxxxxxx>]

On Thu, Aug 21, 2014 at 3:21 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> On Tue, 2014-08-19 at 16:19 -0700, Suriyan Ramasami wrote:
>> @@ -64,11 +70,11 @@ static int exynos5_specific_mapping(struct domain *d)
>>      return 0;
>>  }
>>
>> -static int __init exynos5_smp_init(void)
>> +static int __init exynos_smp_init(paddr_t pa_sysram)
>> [...]
>
>> +static int __init exynos5250_smp_init(void)
>> [...]
>> +static int __init exynos5_smp_init(void)
>
> I'm not sure I grok the intending meaning/distinction of exynos5_* vs
> exynos5250_*. It *looks* like you are using exynos5_* for the 5410
> specific stuff, but I'm not sure (and I'm half suspecting that you are
> using it for both 5410 specific and more general things...).
>
> If that is the case then you really ought to be using exynos5410_* for
> stuff which is specific to that chip.
>
> Perhaps exynos5xxx_* would be less confusing for the generic stuff, but
> just avoiding using exynos5_* for 5410 specific stuff would be
> sufficient.
>
Thank you Ian for the review and suggestion. I shall use exynos5xxx_*
for generic and exynos5410_* and exynos5250_* names in my next
iteration.

> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel