Re: [Xen-devel] [PATCH v2 1/2] x86: add p2m_mmio_write_dm

["Ye, Wei" <wei.ye@xxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Friday, August 22, 2014 6:13 PM
> To: Ye, Wei; xen-devel@xxxxxxxxxxxxx
> Cc: Tian, Kevin; keir@xxxxxxx; ian.campbell@xxxxxxxxxx;
> stefano.stabellini@xxxxxxxxxxxxx; tim@xxxxxxx; ian.jackson@xxxxxxxxxxxxx;
> Dugger, Donald D; Paul.Durrant@xxxxxxxxxx; Lv, Zhiyuan; JBeulich@xxxxxxxx;
> Zhang, Yang Z
> Subject: Re: [Xen-devel] [PATCH v2 1/2] x86: add p2m_mmio_write_dm
> 
> On 22/08/14 20:18, Wei Ye wrote:
> > Add an new p2m type p2m_mmio_write_dm. Page of this type is read only,
> > and write will go to the device model for emulation just like a mmio.
> >
> > Signed-off-by: Wei Ye <wei.ye@xxxxxxxxx>
> > ---
> >  xen/arch/x86/hvm/hvm.c    |    3 ++-
> >  xen/arch/x86/mm/p2m-ept.c |    1 +
> >  xen/arch/x86/mm/p2m-pt.c  |    1 +
> >  xen/include/asm-x86/p2m.h |    1 +
> >  4 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index
> > 17ff011..4984149 100644
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -2739,7 +2739,8 @@ int hvm_hap_nested_page_fault(paddr_t gpa,
> >       * to the mmio handler.
> >       */
> >      if ( (p2mt == p2m_mmio_dm) ||
> > -         (access_w && (p2mt == p2m_ram_ro)) )
> > +         (access_w && (p2mt == p2m_ram_ro)) ||
> > +         (access_w && (p2mt == p2m_mmio_write_dm)) )
> 
> Please adjust the position of the logical or.
> 
Ok.

> ~Andrew
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel