Re: [Xen-devel] [PATCH RFC 3/7] xen/arm: Enable the compilation of mem_access and mem_event on ARM.

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Mon, Aug 25, 2014 at 7:25 PM, Andres Lagar Cavilla <andres@xxxxxxxxxxxxxxxx> wrote:

On Fri, Aug 22, 2014 at 2:30 AM, Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx> wrote:

This patch sets up the infrastructure to support mem_access and mem_event
 on ARM and turns on compilation. We define the required XSM functions,
handling of domctl copyback, and the required p2m types and stub-functions
in this patch.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>

Non-ARM bits LGTM to me. I see here the disablement of CONFIG_X86.

If Xen were to ever support another architecture (hello IA64), it might be more reasonable to keep an #ifdef CONFIG_X86 && CONFIG_ARM. I don't know how unlikely that future direction might be.

Andres

Certainly, that would make sure it is more forward compatible.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel