Re: [Xen-devel] [PATCH RFC/WIP 1/4] Introduce SHUTDOWN_kexec shutdown reason

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 26/08/14 13:40, Jan Beulich wrote:
>>>> On 26.08.14 at 12:16, <david.vrabel@xxxxxxxxxx> wrote:
>> On 25/08/14 14:42, Vitaly Kuznetsov wrote:
>>> --- a/xen/include/public/sched.h
>>> +++ b/xen/include/public/sched.h
>>> @@ -158,7 +158,8 @@ DEFINE_XEN_GUEST_HANDLE(sched_watchdog_t);
>>>  #define SHUTDOWN_suspend    2  /* Clean up, save suspend info, kill.       
>>>  
>>  */
>>>  #define SHUTDOWN_crash      3  /* Tell controller we've crashed.           
>>>  
>>  */
>>>  #define SHUTDOWN_watchdog   4  /* Restart because watchdog time expired.   
>>>  
>>  */
>>> -#define SHUTDOWN_MAX        4  /* Maximum valid shutdown reason.           
>>>   
>> */
>>> +#define SHUTDOWN_kexec      5  /* Soft-reboot for kexec.                   
>>>   
>> */
>>
>> I agree with Jan on the name.
>>
>> The documentation also needs to be expanded.  It should be clear that
>> this hypercall may return in a new domain.
> 
> Perhaps s/may/will/ ?

Yes, but only on success.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel