Re: [Xen-devel] [PATCH v1 1/4] xen: add real time scheduler rt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.14 at 00:58, <mengxu@xxxxxxxxxxxxx> wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h

Just a couple of comments on the interface changes; I'll leave the
actual scheduler code to the scheduler specialists.

> @@ -367,6 +383,16 @@ struct xen_domctl_scheduler_op {
>          struct xen_domctl_sched_credit2 {
>              uint16_t weight;
>          } credit2;
> +        struct xen_domctl_sched_rt{

Missing blank before {.

> +            /* get vcpus' params */
> +            XEN_GUEST_HANDLE_64(xen_domctl_sched_rt_params_t) vcpu;

Why does this need to be a handle? Do you permit setting these
to different values for different vCPU-s? Considering that other
schedulers don't do this, why does yours need to?

> +            uint16_t nr_vcpus;
> +            /* set one vcpu's params */
> +            uint16_t vcpu_index;
> +            uint16_t padding[2];
> +            uint64_t period;
> +            uint64_t budget;

Are values overflowing 32 bits here really useful/meaningful?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel