Re: [Xen-devel] [PATCH RFC 1/7] xen: Relocate mem_access and mem_event into common.

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Tue, Aug 26, 2014 at 3:34 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 22.08.14 at 11:30, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> In preparation to add support for ARM LPAE mem_event, relocate mem_access
> and mem_event into common Xen code. This patch makes no functional changes
> to the X86 side, for ARM mem_event and mem_access functions are just
> placeholder stubs.

"Makes no functional changes" is a little too weak a statement to
efficiently review such a big patch: Please clarify how much of the
non-benign changes (like asm/ -> xen/ include file path adjustments)
is really just code movement vs. where you needed to actually alter
the code.

OK, I'll do that in the next version!

 

>  xen/arch/x86/domctl.c            |   2 +-
>  xen/arch/x86/hvm/hvm.c           |  61 +---
>  xen/arch/x86/mm/Makefile         |   2 -
>  xen/arch/x86/mm/hap/nested_ept.c |   2 +-
>  xen/arch/x86/mm/hap/nested_hap.c |   2 +-
>  xen/arch/x86/mm/mem_access.c     | 133 --------
>  xen/arch/x86/mm/mem_event.c      | 705 --------------------------------------
>  xen/arch/x86/mm/mem_paging.c     |   2 +-
>  xen/arch/x86/mm/mem_sharing.c    |   2 +-
>  xen/arch/x86/mm/p2m-pod.c        |   2 +-
>  xen/arch/x86/mm/p2m-pt.c         |   2 +-
>  xen/arch/x86/mm/p2m.c            |   2 +-
>  xen/arch/x86/x86_64/compat/mm.c  |   4 +-
>  xen/arch/x86/x86_64/mm.c         |   4 +-
>  xen/common/Makefile              |   2 +
>  xen/common/domain.c              |   1 +
>  xen/common/mem_access.c          | 137 ++++++++
>  xen/common/mem_event.c           | 707 +++++++++++++++++++++++++++++++++++++++
>  xen/common/memory.c              |  62 ++++
>  xen/include/asm-arm/mm.h         |   1 -
>  xen/include/asm-x86/hvm/hvm.h    |   6 -
>  xen/include/asm-x86/mem_access.h |  39 ---
>  xen/include/asm-x86/mem_event.h  |  82 -----
>  xen/include/asm-x86/mm.h         |   2 -
>  xen/include/xen/mem_access.h     |  58 ++++
>  xen/include/xen/mem_event.h      | 141 ++++++++
>  xen/include/xen/mm.h             |   6 +
>  27 files changed, 1128 insertions(+), 1041 deletions(-

This changes maintainership of a couple of files without also
adjusting ./MAINTAINERS.

The only code that is shifted is the mem_event/mem_access code and I don't see entries for them in MAINTAINERS, so I think they would still just fall under "THE REST". If there are other maintainership changes caused by this patch that I'm unaware of please let me know and I'll adjust the MAINTAINERS.

 

>  delete mode 100644 xen/arch/x86/mm/mem_access.c
>  delete mode 100644 xen/arch/x86/mm/mem_event.c
>  create mode 100644 xen/common/mem_access.c
>  create mode 100644 xen/common/mem_event.c
>  delete mode 100644 xen/include/asm-x86/mem_access.h
>  delete mode 100644 xen/include/asm-x86/mem_event.h
>  create mode 100644 xen/include/xen/mem_access.h
>  create mode 100644 xen/include/xen/mem_event.h

Doesn't git have a mode where moves can be reflected as ordinary
diffs rather than as deletes/creates? While I'm not sure my scripts
would cope with applying such a patch, it surely would make review
easier (and perhaps even eliminate the question raised at the top).

Jan

I did git mv to relocate the files and that does delete mode/create mode. I don't know if there is way to do what you describe but I'll look into it.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel