[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/13] Config.mk: replace dependency to genpath with actual target

On Mon, 2014-07-28 at 11:05 +0200, Olaf Hering wrote:

Sorry for the delay in looking into this, I've been on vacation and

> genpath is a detail of buildmakevars2file. Replace the dependency to
> genpath with the actual buildmakevars2file target. This change by
> itself does not fix any bug. Upcoming changes will add dependencies to
> $(target), but no rule exist to create $(target).
> No change in behaviour is expected by this patch.
> Note: target.tmp ($(1).tmp) is not marked as .PHONY because
> move-if-changed in the target rule will remove target.tmp by renaming
> it to target. As a result make will always attempt to rebuild it.

Does the scheme you've got here end up differing from:

       rm -f $(1).tmp; \
        $(foreach var, $(BUILD_MAKE_VARS), \
                 echo "$(var)=\"$($(var))\"" >>$(1).tmp;) \
        $(call move-if-changed,$(1).tmp,$(1))

(i.e. avoiding the $(1).tmp rule)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.