Re: [Xen-devel] [PATCH v2 03/18] libxl: functions to lock / unlock domain data in libxl user data store

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote:
> The term "domain data" means libxl's knowledge of a domain, which
> includes but not limit to domain configuration. A new "libxl-lock" entry

"is not limited to"

> Portability note: this lock utilises flock(2) so a proper implementation
> of flock(2) is required.

I suppose Linux provides this, do you know about BSD? (IOW, how much of
a problem is this in reality)

> + *  "libxl-lock"  lock file to protect domain data in libxl. It's per-domain

"It's a per-domain..." or just "Per-domain...".

> +            default:
> +                /* All other errno: EBADF, EINVAL, ENOLCK, EWOULDBLOCK */
> +                LOGE(ERROR,
> +                     "unexpcted error while trying to lock %s, fd=%d, 
> errno=%d",

"unexpected"

Other than those nits: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel