[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 16/18] libxl: introduce libxl_userdata_unlink
On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote: > + CTX_LOCK; > + lock = libxl__lock_domain_data(gc, domid); > + if (!lock) { This seems like a quirk which deserves commenting on since this lock only protects a specific type of userdata, specifically the libxl-json userdata. Any app defined data is not actually protected by this lock in general. I haven't yet seen the caller but it seems odd that the application would be allowed to unlink the libxl-json file, so I'm not sure why this function needs to worry about the lock (instead of insisting that the libxl-internal caller deals with it) Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |