Re: [Xen-devel] [PATCH v6 2/2] x86/viridian: Add partition time reference counter MSR support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.14 at 15:07, <paul.durrant@xxxxxxxxxx> wrote:
> +    case VIRIDIAN_MSR_TIME_REF_COUNT:
> +    {
> +        uint64_t tsc;
> +
> +        if ( !(viridian_feature_mask(d) & HVMPV_time_ref_count) )
> +            return 0;
> +
> +        perfc_incr(mshv_rdmsr_time_ref_count);
> +        tsc = hvm_get_guest_tsc(pt_global_vcpu_target(d));
> +        *val = (tsc * 10000ull) / d->arch.tsc_khz;

There was a very relevant comment on the potential overflow of
the multiplication here for the previous version, yet you neither
addressed that verbally nor by adjusting the code.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel