Re: [Xen-devel] [PATCH RFC v2 03/12] xen/mem_event: Relax error condition on debug builds

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Wed, Aug 27, 2014 at 6:39 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:

A faulty tool stack can brick a debug hypervisor. Unpleasant while dev/test.

Suggested-by: Andres Lagar Cavilla <andres@xxxxxxxxxxxxxxxx>
Signed-off-by: Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>
---
  xen/common/mem_event.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c
index e22b78e..8be32e1 100644
--- a/xen/common/mem_event.c
+++ b/xen/common/mem_event.c
@@ -279,7 +279,11 @@ void mem_event_put_request(struct domain *d,
      if ( current->domain != d )
      {
          req->flags |= MEM_EVENT_FLAG_FOREIGN;
-        ASSERT( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) );
+#ifndef NDEBUG
+        if ( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) )
+            printk(XENLOG_G_WARNING
+                   "VCPU was not paused.\n");

NIT: Can't your write the message on the previous line?

Regards,

--
Julien Grall

Ah, yes, that's just an artifact as I had a longer message printed first and didn't adjust the line after I shortened it.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel