Re: [Xen-devel] [PATCH RFC V10 5/5] xen: Handle resumed instruction based on previous mem_event reply

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.14 at 15:36, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 08/28/2014 04:31 PM, Jan Beulich wrote:
>>>>> On 28.08.14 at 15:10, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> +static bool_t vmx_exited_by_nested_pagefault(void)
>>> +{
>>> +    unsigned long exit_qualification;
>>> +
>>> +#ifndef NDEBUG
>>> +    unsigned long exit_reason;
>>> +    __vmread(VM_EXIT_REASON, &exit_reason);
>>> +    ASSERT(exit_reason == EXIT_REASON_EPT_VIOLATION);
>>> +#endif
>> 
>> This #ifdef-ery is pointless afaict.
> 
> I thought I'd save a __vmread() call if Xen is not being compiled in
> debug mode. I'll remove it.

Yeah, we ought to reconsider the volatile-s on those asm()-s, to
allow the compiler to eliminate such. At least on the vmread this
would seem okay to me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel